-
Notifications
You must be signed in to change notification settings - Fork 226
DynamicPPL 0.36 #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
penelopeysm
wants to merge
5
commits into
main
Choose a base branch
from
py/dppl-0.36
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DynamicPPL 0.36 #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f01fcf1
to
2327e65
Compare
2327e65
to
c699b8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
+ Coverage 84.05% 84.10% +0.05%
==========================================
Files 21 21
Lines 1455 1460 +5
==========================================
+ Hits 1223 1228 +5
Misses 232 232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 14697846792Details
💛 - Coveralls |
54ea767
to
30333d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility with DynamicPPL 0.36.
Given that there are some reasonably breaking changes in the way that submodels behave, I've decided to increment the minor version number.
This PR supersedes the CompatHelper ones at #2532 #2533
Two problems right now:
(1) Prefixing broke Gibbs - this MWE works with DPPL 0.35.9 (main), fails with 0.36.0 (this PR)
I pushed a fix for this with
aaa20c2e
, but I think I need to understand GibbsContext more carefully to make sure that it is the correct fix.Note that it's also quite likely that the change in DynamicPPL submodel prefixing behaviour means that it's now no longer possible to use Gibbs to sample prefixed submodel variables, because submodel variables now no longer have identity lenses. The current simplest workaround is for the user to not use prefixing. The proper solution is to fix #2403.
(2) There's some nasty lack of reproducibility in HMCDA sampling in test/mcmc/Inference. It's not introduced by this PR because the last CI run on main was already failing. I can't yet repro this locally.