Skip to content

fixed some minor dark-theme errors #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jitendravjh
Copy link
Contributor

@jitendravjh jitendravjh commented May 15, 2025

fixed some minor dark-theme errors. Closes #600

@shravanngoswamii shravanngoswamii self-requested a review May 15, 2025 16:28
@shravanngoswamii
Copy link
Member

shravanngoswamii commented May 15, 2025

@penelopeysm Did we remove the pull_request_target event from Preview workflow in this repo? If we did this for security reasons then, Is there any reason we are still using pull_request_target in remove_preview workflow? I suppose we can use pull_request event in remove_preview too, as we are already not generating docs for PRs from forks! And we should skip running both workflows in case of PR from forks, I guess to avoid unnecessary failures!

Do you want me to update it?

@jitendravjh
Copy link
Contributor Author

jitendravjh commented May 15, 2025

These lines in dark mode are looking a bit weird, but I guess you guys are already changing theme in TuringLang/turinglang.github.io#119 so It's better to fix it there!

Light Mode Dark Mode
Table in light-theme Table in dark-theme

@shravanngoswamii
Copy link
Member

Thanks @jitendravjh! I am approving this, code blocks are appearing fine in dark mode too after this PR!

@shravanngoswamii shravanngoswamii merged commit dd621b2 into TuringLang:main May 15, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some output blocks have bad fonts in dark mode
2 participants