Skip to content

Sort people within lists by surname, add myself #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Sort people within lists by surname, add myself #106

merged 2 commits into from
Oct 28, 2024

Conversation

penelopeysm
Copy link
Member

  • Add myself to the team
  • Sort people within team by surname (except for PIs)

Copy link
Contributor

Preview the changes: https://turinglang.org/pr-previews/106
Please avoid using the search feature and navigation bar in PR previews!

@shravanngoswamii
Copy link
Member

Sort people within team by surname (except for PIs)

Instead of doing this manually, let's add a sort function in team.ejs so people don't have to add names in between of team.yaml! I will update ejs file in py/me!

@penelopeysm
Copy link
Member Author

@shravanngoswamii Oh, that's a good shout! I didn't realise you could do that, thanks :)

Just to keep you in the loop, I dropped Hong a message too just to check with him if it's ok to sort, and I'd like to see his response before potentially merging :)

@shravanngoswamii
Copy link
Member

Just to keep you in the loop, I dropped Hong a message too just to check with him if it's ok to sort, and I'd like to see his response before potentially merging :)

Ok, let me know what he says!

@shravanngoswamii
Copy link
Member

@penelopeysm I have added EJS script to sort member by last name, it keeps first two team members of team.yml unsorted! Feel free to merge this once Hong approve it, or else you can hard reset this branch to 7a0552c commit and shift your name to wherever you like!

@yebai yebai merged commit a80e69e into main Oct 28, 2024
3 checks passed
@yebai yebai deleted the py/me branch October 28, 2024 17:35
@yebai
Copy link
Member

yebai commented Oct 28, 2024

Thanks @penelopeysm and @shravanngoswamii!

github-actions bot added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants