Move data directory to ~/.local/share/barony #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically it is not how XDG dictates it should be, but for most users that will work just fine
These directories are for fmodengine on Arch Linux from the AUR package https://aur.archlinux.org/packages/fmodengine
Author
|
Ideally this should use XDG_DATA_HOME if possible, perhaps also copy old data from ~/.barony if it exists, and XDG_DATA_HOME/barony doesn't. Any feedback will be appreciated |
- Use $XDG_DATA_HOME/barony if the variable is longer than 0 (exists), otherwise fallback to $HOME/.local/share/barony - Made `basepath` a sting that already includes the barony folder in it, because it was getting added to `basepath` everywhere anyway - Replaced `mkdir(outputdir, 0777)` with `std::filesystem::create_directories`, which should check if all directories before target exist and create them if they don't.
|
agree this is a good idea |
shinysocks
reviewed
Jan 30, 2026
Author
There was a problem hiding this comment.
Include of header files provided by fmod package from AUR. Can be removed.
There was a problem hiding this comment.
this looks good and I like the idea, I'm probably not qualified to review and unable to run it myself though..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884
Also adds directories of fmodengine from AUR package to the cmake file.