-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-13998] make url of X-Tyk-Upstream optional when loadBalancing is present #6860
[TT-13998] make url of X-Tyk-Upstream optional when loadBalancing is present #6860
Conversation
Let's make that PR title a 💯 shall we? 💪 Your PR title and story title look slightly different. Just checking in to know if it was intentional!
Check out this guide to learn more about PR best-practices. |
API Changes no api changes detected |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
57feb78
to
82f8b2e
Compare
82f8b2e
to
0ff01a4
Compare
0ff01a4
to
0d1893e
Compare
|
User description
TT-13998
This PR makes
upstream.url
optional whenupstream.loadBalancing[].targets.url
is present.Types of changes
PR Type
Bug fix
Description
Made
upstream.url
optional whenloadBalancing
is present.Updated OAS schema to include
oneOf
validation forurl
orloadBalancing
.Changes walkthrough 📝
x-tyk-api-gateway.json
Update OAS schema to validate `url` or `loadBalancing`
apidef/oas/schema/x-tyk-api-gateway.json
required
array withoneOf
validation.url
orloadBalancing
is required.