feat: More generic type guards #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
reviewed
Aug 6, 2025
packages/core/src/extensions/SuggestionMenu/getDefaultSlashMenuItems.ts
Outdated
Show resolved
Hide resolved
nperez0111
reviewed
Aug 6, 2025
| if ( | ||
| editorHasBlockWithTypeAndProps(editor, "heading", { | ||
| level: defaultBlockSpecs["heading"].config.propSchema.level, | ||
| isToggleable: { |
There was a problem hiding this comment.
Let's think ahead here & try to figure out how this would work for both the current schema system & a zod-based one. I'm not sure that we should have to pass a propschema into this function.
I guess there are two types of checks we may want:
- checking that a prop exists in the schema (i.e. does this editor even support toggle blocks)
- checking that a prop matches a shape we expect for this function (i.e. is
isToggleablea boolean)
How might we express that with zod?
I think in zod, whether a prop exists is easy, is there a zod validator for this key. (I also have the feeling this is the more common check).
Then to actually check if it fits what we expect, we would have to run the validator?
So maybe these checks should be de-coupled, i.e. separate checks?
matthewlipski
commented
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.