Skip to content

Catch webpack failures #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/hooks/tap-error-to-log-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,28 @@ function tapErrorToLogMessage(
compiler: webpack.Compiler,
config: ForkTsCheckerWebpackPluginConfig
) {

// If the webpack build fails independently from fork-ts-checker-webpack-plugin,
// it will stop the RPC server with a SIGTERM. Here we catch this case.
let webpackFailed = false;
compiler.hooks.compile.tap('ForkTsCheckerWebpackPlugin', (error) => {
webpackFailed = false;
});
compiler.hooks.failed.tap('ForkTsCheckerWebpackPlugin', (error) => {
webpackFailed = true;
});

const hooks = getPluginHooks(compiler);

hooks.error.tap('ForkTsCheckerWebpackPlugin', (error) => {
if (error instanceof AbortError) {
return;
}

if (webpackFailed) {
return;
}

config.logger.error(String(error));

if (error instanceof RpcExitError) {
Expand Down
Loading