Fix build failures - #30
Merged
Merged
Conversation
- x264: switch from code.videolan.org (returning HTTP 502) to
ibaoger/x264 GitHub mirror; same commit and same SHA512 since
both tarballs unpack to an identically-named top-level directory
- libass: add overlay port (version 0.17.4#1) with two fixes:
1. Android/non-desktop cross-compile: add -Dfontconfig=disabled
alongside -Drequire-system-font-provider=false so meson does
not try to compile ass_fontconfig.c (fontconfig headers are
absent on Android)
2. macOS: promote fontconfig from linux-only to linux|osx vcpkg
dependency so vcpkg builds its own fontconfig (NLS disabled,
no -lintl), avoiding the Homebrew fontconfig 2.18.0 -lintl
linker error on arm64
Copilot
AI
changed the title
fix: x264 mirror and libass Android/macOS build failures
fix: resolve 7 failing CI jobs (x264 502, libass Android/macOS)
Jun 1, 2026
Copilot created this pull request from a session on behalf of
Tyrrrz
June 1, 2026 09:58
View session
Copilot
AI
changed the title
fix: resolve 7 failing CI jobs (x264 502, libass Android/macOS)
Revert x264 source from third-party GitHub mirror to official code.videolan.org
Jun 1, 2026
Owner
|
@copilot update the PR description with a proper change summary |
Tyrrrz
marked this pull request as ready for review
June 1, 2026 10:33
Tyrrrz
changed the title
Contributor
Author
Done — also fixed a |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates vcpkg overlay ports used by the FFmpeg dependency set to address build reliability/supply-chain concerns and to add/adjust an overlay for libass.
Changes:
- Update the
x264overlay to use the upstream GitLab repo’sstablebranch asHEAD_REF. - Add a new
libassoverlay port (manifest + portfile) using Meson, including an ARM64 Windows assembly build patch.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| overlays/ports/x264/portfile.cmake | Adjusts HEAD_REF to stable for x264’s upstream GitLab source fetch. |
| overlays/ports/libass/vcpkg.json | Adds a new overlay manifest for libass with its dependencies. |
| overlays/ports/libass/portfile.cmake | Implements the libass overlay build via Meson and configures asm tooling per-arch. |
| overlays/ports/libass/arm64-windows-asm.patch | Patches libass Meson logic to build AArch64 .S sources on Windows via clang. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The x264 overlay was downloading from
ibaoger/x264(an unofficial GitHub mirror) to work around intermittent HTTP 502s oncode.videolan.org. This introduces supply chain risk; vcpkg's built-in download retry is sufficient to handle transient failures.Changes
overlays/ports/x264/portfile.cmake: Replacevcpkg_from_github(REPO ibaoger/x264 …)withvcpkg_from_gitlab(GITLAB_URL https://code.videolan.org/ REPO videolan/x264 …). SHA512 is unchanged — archives are byte-for-byte identical.