-
Notifications
You must be signed in to change notification settings - Fork 4
More unit tests for MATLAB replacer classes #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Recursive globbing unit test source files. * Specify test_*.cpp Co-authored-by: Will Graham <[email protected]> Co-authored-by: Will Graham <[email protected]>
Co-authored-by: Sam Cunliffe <[email protected]>
…graham-more_array_tests
…nto wgraham-even_more_array_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Despite my picky comments about using full words for variables these are all nice tests.
Just to be clear: both me and Google prefer full names wherever possible...
Do not worry about saving horizontal space as it is far more important to make your code immediately understandable by a new reader.
Perhaps the only exception for us is if it's actually the name of a maths symbol from Peter's thesis/convention e.g.
Will need to go through and check for consistency Co-authored-by: Sam Cunliffe <[email protected]>
Vertices
class | Closes #170initialise()
successfully assigns memory and decrements all stored values by 1, to be consistent withC++
, rather than MATLAB indexing.FieldComponentsVector
class | Closes #172ComplexAmplitudeSample
class | Closes #173components
andvertices
.GratingStructure
class | Closes #174Pupil
class | Closes #175initialise()
method performs correctly, given the MATLAB inputEHVec
class | Closes #176fftw_complex
to the entries of the objectfftw_free
used in destructorFrequencyExtractVector
class | Closes #177max()
function correctly identifies maximal elementCCollection
class | Closes #178struct
passed is of the wrong shape/sizeis_disp_ml
andis_multilayer
are "correctly" identified, although has flagged a logical flaw in one of theseDCollection
class | Closes #179CCollection
, minus the possibility of being provided with 9 fields over 6.CMaterial
class | Closes #184matlabio.cpp
to avoid seg-faults if the input has an incorrect fieldnameDMaterial
class | Closes #185CMaterial
barring a6
instead of a9
.