Add dependence on libhdf5 and basic implementation class structure.
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mosè Giordano <[email protected]> Co-authored-by: Will Graham <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
===================================
Coverage 24% 25%
===================================
Files 64 65 +1
Lines 3595 3627 +32
===================================
+ Hits 870 893 +23
- Misses 2725 2734 +9
☔ View full report in Codecov by Sentry. |
Basic class structure and some failing tests for TDD.
…se of stupid, not TDD.
|
I think this is a good first bite of the HDF5 stuff. Let's both review it. |
samcunliffe
commented
May 19, 2023
tdms/src/hdf5_io.cpp
Outdated
Comment on lines
98
to
101
| bool HDF5Base::is_ok() const { | ||
| return true; | ||
| // | ||
| } |
There was a problem hiding this comment.
This is aspirational and we may want to remove it.... @willGraham01 what do you think? Should we remove it here? Probably yes.
samcunliffe
added
the
review required
willGraham01
approved these changes
May 19, 2023
This was referenced May 20, 2023
giordano
deleted the
181-hdf5-first-part-extracted-from-pairdev-working-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cherry-pick of the first few commits of #250 for factorised review.
First part of (does not solve)
Supercedes