Refactor [2/N] #88
Merged
Refactor [2/N] #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused pointers Don't throw with unused Add pkg executable Refactor numeric.cpp Refactor numerical_derivative Start iterator refactor Add timers Add catch2 fetch message Don't narrow int Doc + indentation + type decl Delete unused pragmas on CI Add simulation params struct remove unused globals Extract angular norms Add H field test Fix time order Use relative difference Use built in pi constant Use langle rangle auto types Include math defines Delete unused code Fix typo in tdms/include/globals.h Revert pi import
* Apply useCD as a compile time flag * Extract grid labels * Use E/H classes for split field pointers * Add ft to E/H attributes * Separate split and regular fields * Use E/H classes in functions
* Add destructors and allocation to split field * Delete unused function declaration * Use split fields in extractPhasors Co-authored-by: David Stansby <[email protected]>
* Convert tabs to spaces * clang format
* Add test for allocation and zeroing * Loops over components * Associate bounds with E * Make normalise volume a method * Fix typo * Change int to bools * Extract ex_tdf save * Fix dividing by zero
* Extract init grid tensors * Remove unused file * Use a zero function on exported fields * Add index bounds to fields * Add docstrings
* Use a shared phasor extract function * Use index operator for indexing * Delete unused code * Delete unused yaml if * Move timer doc to header * Delete more unused code
* Extract C and D materials
* Extract freespace and alpha beta gamma * Extract delta * Extract interface components * Remove unused array * Rename xyz_arrays * Extract source tensors
* Extract grid labels * Extract omega_an * Extract dt and hwhm * Extract pml and Nt * Extract start tind
* Extract phasor extraction * Use ++ to increment argument counter * Use unsigned ints for iteration * Add enums and set methods * Extract rho * Extract ml * Extract cuboid * Reorder dimension enum Co-authored-by: Sam Cunliffe <[email protected]>
* Use templated array casts and frees * Extract structure * Extract f_ex_vec * Extract f_vec * Renaming * Template vectors and matrices * Extract pupil * Extract D_tilde * Apply doc improvements from code review [skip actions] Co-authored-by: Sam Cunliffe <[email protected]>
* Extract simple parameters * Extract interpolation method * Change extractPhasorsSurface signature * Extract exi eyi * Use string_in * Extract phasorinc Co-authored-by: Sam Cunliffe <[email protected]>
* Extract fieldsample * Extract campssample
* Extract Ex_t Ey_t * Extract Np Npe * Extract cx_vec * Extract eh_vec * Extract fftw plan * Use bool not int flags * Use variable for indexing
samcunliffe
approved these changes
Sep 28, 2022
|
Conflicts. |
prmunro
approved these changes
Sep 29, 2022
t-young31
force-pushed
the
refactor_chunked
branch
from
f982ca4 to
9582f16
Compare
t-young31
commented
Oct 2, 2022
t-young31
force-pushed
the
refactor_chunked
branch
from
cd7c1b8 to
eb7585a
Compare
3 tasks
samcunliffe
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #63
I'd strongly recommend we add some more comprehensive system tests before merging this.
Guidelines for reviewers
These commits have been reviewed as separate PRs on my fork previously. If this PR warrants further review I'd strongly recommend reviewing the individual commits, with the exception of the one that just clang-formats the entire
iterator.cppfile.Extensions
arrays.h) to something more robust.clang-formatfile to reformat the entire code base (ideally as a precommit hook)Dependencies