Open
Conversation
justin-phxm
requested review from
IshaHaider,
haley-lynn,
ideen1 and
jjason-nn
ideen1
reviewed
Nov 10, 2023
|
|
||
| <button | ||
| *ngIf="item.isBorrowable !== true" | ||
| (click)="openModal(item)" |
Contributor
There was a problem hiding this comment.
Can we use a more descriptive name for the modal here?
Collaborator
Author
There was a problem hiding this comment.
Ideen is talking about the name openModal. He says to rename it to openMultipleItemModal.
| </div> | ||
|
|
||
| <dialog id="myModal"> | ||
| <button style="color: red; font-size: larger" (click)="closeModal()"> |
| setItemAmount(amount: number) { | ||
| this.useItemAmount = amount; | ||
| } | ||
| openModal(modalItem: Item) { |
ideen1
reviewed
Nov 18, 2023
| } | ||
| ::backdrop { | ||
| background-color: slategray; | ||
| /* background-image: linear-gradient( |
Contributor
There was a problem hiding this comment.
Please remove the commented CSS code
…into TEL-2-portal-password-requirements-should-be-the-same-when-resetting-as-when-registering-or-logging-in
justin-phxm
force-pushed
the
master
branch
4 times, most recently
from
e63bc81 to
b0f0223
Compare
burtonjong
force-pushed
the
master
branch
6 times, most recently
from
2e7ee9e to
5c958ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.