-
Notifications
You must be signed in to change notification settings - Fork 278
fix(ui5-button): remove reference to last clicked button #12370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I could not think of a valid test for this scenario as Cypress doesnt even have access to the variable, so the fix was only tested manually |
🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12370/ The preview will be updated automatically when you push new commits to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove it at all or should we remove it only when destroyed? I remeber we had a conversation to remove it only when destroyed. Do we know why it was set there to remove it without more testing?
🚀 Deployed on https://pr-12370--ui5-webcomponents-preview.netlify.app |
As far as I've tested, it's used only to update the We discussed I think the possibility that it was used by the split button, but the split button has it's own |
Fixes: #11865