Skip to content

Conversation

didip1000
Copy link
Contributor

Fixes: #11865

@didip1000
Copy link
Contributor Author

I could not think of a valid test for this scenario as Cypress doesnt even have access to the variable, so the fix was only tested manually

@ui5-webcomponents-bot
Copy link
Collaborator

🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12370/

The preview will be updated automatically when you push new commits to this PR.

Copy link
Contributor

@tsanislavgatev tsanislavgatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove it at all or should we remove it only when destroyed? I remeber we had a conversation to remove it only when destroyed. Do we know why it was set there to remove it without more testing?

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Sep 26, 2025

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview September 26, 2025 13:38 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview September 26, 2025 13:57 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview September 26, 2025 14:22 Inactive
@didip1000
Copy link
Contributor Author

Should we remove it at all or should we remove it only when destroyed? I remeber we had a conversation to remove it only when destroyed. Do we know why it was set there to remove it without more testing?

As far as I've tested, it's used only to update the active property which is private and used to denote the active state of the button. In the CSS you can replace [active] with :active everywhere where it's used and the button, toggle button, and split button appear to continue working properly. I'm not sure why it was added in the first place (it was added a long time ago) and I could be missing something.

We discussed I think the possibility that it was used by the split button, but the split button has it's own activeArrowButton which doesn't seem related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-button]: Reference to last clicked button kept even if destroyed
5 participants