Skip to content

fix(ui5-dynamic-page): improve focus visibility for keyboard navigation #12372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(ui5-dynamic-page): improve focus visibility for keyboard navigation #12372

wants to merge 8 commits into from
+36 −2

Conversation

NakataCode
Copy link
Contributor

@NakataCode NakataCode commented Sep 25, 2025 •
edited
Loading

  • Add focusin event listener to scroll container
  • Exclude header and title elements to prevent unwanted scroll behavior
  • Use scrollIntoView with smooth animation and nearest block positioning
  • Properly manage event listener lifecycle in onAfterRendering/onExitDOM

Fixes: #11710

@ui5-webcomponents-bot
Copy link
Collaborator

🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12372/

The preview will be updated automatically when you push new commits to this PR.

@NakataCode NakataCode marked this pull request as ready for review September 25, 2025 11:12
@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Sep 26, 2025 •
edited
Loading

🚀 Deployed on https://pr-12372--ui5-webcomponents-preview.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview September 26, 2025 13:38 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview September 26, 2025 13:57 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview September 26, 2025 14:22 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 2, 2025 11:47 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview October 2, 2025 12:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgogov kgogov Awaiting requested review from kgogov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SF-ACC][DynamicPage]: field is partly visible when using tab key
3 participants
@NakataCode @ui5-webcomponents-bot @ilhan007