test(ui5-busy-indicator): add more tests to improve code coverage #12395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: BGSOFUIRODOPI-3540
dimovpetar
requested changes
Sep 30, 2025
dimovpetar
requested changes
Oct 3, 2025
| cy.get("[ui5-busy-indicator]").invoke("removeAttr", "active"); | ||
|
|
||
| // Wait for the original delay period | ||
| setTimeout(() => {}, 1300); |
There was a problem hiding this comment.
This setTimeout is not awaited by anything.
I recommend to change the entire test like this
cy.mount(
<BusyIndicator delay={1200}>
<div>Content</div>
</BusyIndicator>
);
// Activate the busy indicator
cy.get("[ui5-busy-indicator]").invoke("attr", "active", "");
// Verify it's not busy yet (delay hasn't passed)
cy.get("[ui5-busy-indicator]")
.shadow()
.find(".ui5-busy-indicator-busy-area")
.should("not.exist");
cy.get<BusyIndicator>("[ui5-busy-indicator]").should(($el) => {
const timeoutId = $el[0]._busyTimeoutId;
expect(timeoutId).to.exist;
}).then(($el) => {
cy.wrap($el[0]._busyTimeoutId).as("timeoutId");
});
const clearTimeoutSpy = cy.spy(clearTimeout);
// Deactivate before delay passes - this should trigger the timeout cleanup
cy.get("[ui5-busy-indicator]").invoke("removeAttr", "active");
cy.get("[ui5-busy-indicator]")
.shadow()
.find(".ui5-busy-indicator-busy-area")
.should("not.exist");
cy.get("@timeoutId")
.should((timeoutId) => {
// expect(timeoutId).to.exist;
expect(clearTimeoutSpy).to.have.been.calledWith(timeoutId);
});
cy.get("[ui5-busy-indicator]")
.invoke("prop", "_isBusy")
.should("eq", false);There seems to be a bug, because clearTimeout is not called.
| cy.get("[ui5-busy-indicator]").invoke("removeAttr", "active"); | ||
|
|
||
| // Wait longer than the original delay to ensure timeout was cleared | ||
| setTimeout(() => {}, 600); |
There was a problem hiding this comment.
Same as in the test above.
Comment on lines
+339
to
+368
| it("should trigger timeout cleanup when deactivated with pending timeout", () => { | ||
| cy.mount( | ||
| <BusyIndicator delay={1000}> | ||
| <div>Content</div> | ||
| </BusyIndicator> | ||
| ); | ||
|
|
||
| // Test the specific scenario that hits the timeout cleanup lines | ||
| cy.get("[ui5-busy-indicator]").then(($el) => { | ||
| const element = $el[0] as any; | ||
|
|
||
| // Set active to trigger timeout creation | ||
| element.active = true; | ||
|
|
||
| // Manually trigger onBeforeRendering to create the timeout | ||
| element.onBeforeRendering(); | ||
|
|
||
| // Verify timeout was created (should not be busy yet) | ||
| expect(element._isBusy).to.be.false; | ||
| expect(element._busyTimeoutId).to.exist; | ||
|
|
||
| // Now set active to false - this should trigger the cleanup code | ||
| element.active = false; | ||
| element.onBeforeRendering(); | ||
|
|
||
| // Verify cleanup happened | ||
| expect(element._busyTimeoutId).to.be.undefined; | ||
| expect(element._isBusy).to.be.false; | ||
| }); | ||
| }); |
There was a problem hiding this comment.
merge it with the test "should clear timeout when component becomes inactive"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRODOPI-3540