Skip to content

fix(ui5-tab-container): improve overflow behavior test #12422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 14, 2025
Merged

fix(ui5-tab-container): improve overflow behavior test #12422

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b8eadb
fix(ui5-tab-container): stabilize test
s-todorova Oct 2, 2025
8b35c09
Merge remote-tracking branch 'origin/main' into tabcontainer_cy_test
s-todorova Oct 2, 2025
ade15c0
fix(ui5-tab-container): address comments
s-todorova Oct 3, 2025
298e1a2
fix: add assertion
s-todorova Oct 13, 2025
17e1b90
Merge branch 'main' into tabcontainer_cy_test
s-todorova Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/main/cypress/specs/TabContainer.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,8 @@ describe("TabContainer general interaction", () => {
});
});

it.skip("tests start and end overflow behavior - tabs don't move to the right if there is enough space", () => {
it("tests start and end overflow behavior - tabs don't move to the right if there is enough space", () => {
cy.viewport(600, 1080);
cy.mount(
<TabContainer id="tabContainerStartAndEndOverflow" overflowMode="StartAndEnd">
<Tab text="One">Tab 1</Tab>
Expand Down Expand Up @@ -530,14 +531,14 @@ describe("TabContainer general interaction", () => {
</TabContainer>
);

cy.viewport(600, 1080);

cy.get("#tabContainerStartAndEndOverflow").shadow().find(".ui5-tc__overflow--start").as("startOverflow");
cy.get("#tabContainerStartAndEndOverflow").should("have.attr", "overflow-mode", "StartAndEnd");
cy.get("@startOverflow").should("have.text", "+4");

cy.get("@startOverflow").should("be.visible").invoke("text").should("equal", "+4");

cy.get("#tabContainerStartAndEndOverflow").shadow().find(".ui5-tab-strip-item:nth-child(5)").as("tab5");
cy.get("@tab5").click();
cy.get("#tabContainerStartAndEndOverflow").shadow().find(".ui5-tab-strip-item:visible:not([hidden])").first().as("visibleTab");
cy.get("@visibleTab").should("exist");
cy.get("@visibleTab").realClick();

cy.get("@startOverflow").should("have.text", "+4");
});
Expand Down
Loading