fix(ui5-tab-container): allow selection indicator on text-only tabs to overlap bottom border #12584
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selection indicator of text only tabs shows above the bottom border Fixes: #12538
Collaborator
|
🚀 Deployed on https://pr-12584--ui5-webcomponents-preview.netlify.app |
Please consider: The selection indicator for text-only tabs appears above the bottom border. |
Stoev
reviewed
Oct 30, 2025
Stoev
left a comment
Stoev
left a comment
There was a problem hiding this comment.
Please consider, this is a bit long, but it's exactly the allowed limit of 100 characters:
fix(ui5-tab-container): prevent selection indicator on text-only tabs from overlapping bottom border
kskondov
changed the title
Stoev
approved these changes
Oct 31, 2025
GerganaKremenska
requested changes
Nov 3, 2025
… from overlapping bottom border Address review comments
…container-selection-border
…i5-webcomponents into ui5-tab-container-selection-border
… from overlapping bottom border Fix overlapping
… from overlapping bottom border Fix blank lines
kskondov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selection indicator for text-only tabs overlaps the bottom border.
Fixes: #12538