fix(ui5-popover): fix horizontal placement (Start and End) in rtl mode #12606
+170
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-12606--ui5-webcomponents-preview.netlify.app |
TeodorTaushanov
changed the title
TeodorTaushanov
requested review from
a team,
MapTo0,
NHristov-sap,
Stoev,
dobrinyonkov and
pskelin
pskelin
reviewed
Nov 4, 2025
|
|
||
| if (this.isRtl) { | ||
| if (placement === PopoverPlacement.Start) { | ||
| placement = PopoverPlacement.End; |
There was a problem hiding this comment.
Start means start regardless of RTL, I find this confusing. Maybe you want to use Left/Right here? the switch statement below also uses Top/Bottom, which are actual directions and not logical directions.
There was a problem hiding this comment.
The method is called getActualPlacement and we need to calc the actual placement depending on rtl and whether there is a place at the specified placement.
Top/Bottom is another question for another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix horizontal placement (Start and End) in rtl mode
fix usage of placement and horizontalAlign in the framework
fixes #12603