feat: persistent vote details panel with inline voting#438
Open
pumpedlunch wants to merge 3 commits intomasterfrom
Open
feat: persistent vote details panel with inline voting#438pumpedlunch wants to merge 3 commits intomasterfrom
pumpedlunch wants to merge 3 commits intomasterfrom
Conversation
- PanelContext extended with votes array, currentIndex, arrow navigation (nextVote/prevVote), and vote selection callbacks (selectVote/clearVote, selectedVote, phase, activityStatus) injected via openPanel options - Fixed previousPanelData stack unbounded growth: vote panels now replace the stack with a single entry instead of pushing - PanelTitle: removed integration logo (TitleIcon), added left/right arrow buttons that navigate between votes; disabled at list boundaries - VoteButtonRow: new component rendered between PanelTitle and tabs; shows option buttons (P1/P2/P3/P4 with hover tooltip for Polymarket) plus pencil for custom inline input; hidden during reveal phase, for non-active votes, and for MULTIPLE_VALUES identifier votes - ActiveVotes: passes votes array, index, callback factory, and getSelectedVote to openPanel; computes isActiveInPanel per row - VoteTableRow: ring-1 ring-inset indicator on the row currently shown in the panel - Panel/VotePanel: scroll-to-top and tab reset on vote change 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…in vote panel header - Replace ← → text characters with left-chevron.svg icon (flipped for right arrow) - Move close button to top-right corner (top/right: 12px) so it sits above the vertically-centered navigation chevrons without visual conflicts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Don't merge. PR is a work in progress. |
Contributor
Alright Let's mark it as a draft for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ring-1 ring-black ring-insethighlight in the vote tableKey changes
contexts/PanelContext.tsx— extended withvotes[],currentIndex,nextVote/prevVote,selectVote/clearVote,selectedVote,phase,activityStatus; usesuseReffor factory callbacks to avoid stale closurescomponents/Panel/PanelTitle.tsx— added chevron navigation, removed TitleIcon; usesleft-chevron.svg(flipped for right arrow)components/Panel/VotePanel/VoteButtonRow.tsx— new component; renders vote option buttons and custom pencil inputcomponents/Panel/VotePanel/VotePanel.tsx— addedVoteButtonRow, tab/scroll reset on vote changecomponents/Panel/Panel.tsx— scroll-to-top on vote change; close button repositionedcomponents/Votes/ActiveVotes.tsx— passesvotes,currentIndex, and callback factories toopenPanel; tracks active panel rowcomponents/VoteList/VoteTableRow.tsx—isActiveInPanelring indicatorTest plan