fix: iPad 호환 모드 온보딩 화면 잘림 수정 - #237
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Walkthrough로그인 및 프로필 분석 화면이 짧은 화면에서 콘텐츠를 스크롤할 수 있도록 변경되었습니다. 화면 높이에 따라 일러스트와 팁 박스의 여백을 조정하고, 프로필 미리보기 카드의 최소 높이를 줄였습니다. Changes반응형 화면 레이아웃
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Fixes onboarding UI clipping in iPad “iPhone compatibility mode” (approx. 375×667) by making key screens resilient to shorter heights so CTAs/tip content remain visible and usable.
Changes:
LoginScreen: wrap content in a verticalScrollViewand reduce top illustration margin on compact heights.AnalyzingView: replace absolute-positioned Tip card with natural flow layout inside aScrollViewand adjust spacing for compact heights.CompletePreviewView: lower the preview card minimum height so the bottom CTA is less likely to be pushed off-screen.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/onboarding/login.tsx | Adds scroll fallback + compact top spacing to prevent login CTA clipping on short screens. |
| components/profile/ProfileVoiceParts.tsx | Removes absolute positioning + adds scrolling/compact spacing for analyzing view; reduces preview card min height. |
| {/* 이용약관 바텀시트 */} | ||
| <TermsBottomSheet | ||
| visible={showTermsSheet} | ||
| onConfirm={handleTermsConfirm} | ||
| onClose={() => setShowTermsSheet(false)} | ||
| /> |
Closes #236
변경 사항
원인
iPad의 iPhone 호환 모드(약 375×667)에서 고정 여백, 절대 위치, 큰 최소 높이가 함께 적용되어 하단 콘텐츠가 화면 밖으로 잘렸습니다.
검증
pnpm exec eslint app/onboarding/login.tsx components/profile/ProfileVoiceParts.tsxpnpm exec tsc --noEmitpnpm expo export --platform ios --output-dir /private/tmp/eum-export-responsive --clearSummary by CodeRabbit