Sound pressure api and [in progress]Proximity api#24
Open
adrianariton wants to merge 2 commits intoUPB-CS-OpenSourceUpstream:masterfrom
Open
Sound pressure api and [in progress]Proximity api#24adrianariton wants to merge 2 commits intoUPB-CS-OpenSourceUpstream:masterfrom
adrianariton wants to merge 2 commits intoUPB-CS-OpenSourceUpstream:masterfrom
Conversation
added 2 commits
April 2, 2023 15:24
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Please split this into separate pull requests. There are already some open pull requests about this, maybe you can contribute to those.
|
|
||
| .PHONY: setup | ||
| setup: setup-qemu | ||
| setup: #setup-qemu |
| // Command IDs | ||
|
|
||
| const EXISTS: u32 = 0; | ||
| const READ_TEMP: u32 = 1; No newline at end of file |
| S::command(DRIVER_NUM, 1, 0, 0).to_result() | ||
| } | ||
|
|
||
| pub fn read_proximity_on_interrupt() -> Result<u32, ErrorCode> { |
There was a problem hiding this comment.
Suggested change
| pub fn read_proximity_on_interrupt() -> Result<u32, ErrorCode> { | |
| pub fn enable_interrupt() -> Result<u32, ErrorCode> { |
There was a problem hiding this comment.
Add a comment explaining how this function works.
| S::command(DRIVER_NUM, EXISTS, 0, 0).to_result() | ||
| } | ||
|
|
||
| pub fn read_proximity() -> Result<u32, ErrorCode> { |
There was a problem hiding this comment.
Add a comment explaining how this function works.
There was a problem hiding this comment.
These tests are for the temperature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
sound pressureapi and also started theproximityAPI.