Bug fix to strr_ghost for edge cases with few rows

UPGo-McGill · Feb 23, 2024 · 8adcd8a · 8adcd8a
1 parent a17500c
commit 8adcd8a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/R/strr_ghost.R b/R/strr_ghost.R
@@ -276,6 +276,10 @@ strr_ghost <- function(
                               MoreArgs = list(min_listings = min_listings),
                               SIMPLIFY = FALSE)]
 
+    # Error handling for one-row case where no clusters were identified
+    if (nrow(property) == 1 && is.null(property$data)) 
+      return(ghost_empty(crs_property))
+
     # Get rid of rows without valid tables
     property <- property[!sapply(data, is.null)]
 

diff --git a/R/strr_ghost_helpers.R b/R/strr_ghost_helpers.R
@@ -31,7 +31,9 @@ ghost_date_range <- function(data, dates, min_listings) {
     start = dates[-length(dates)], end = dates[-1] - 1)
 
   date_table[, PID := mapply(\(start, end) sort(data[
-    created <= start & scraped >= end]$property_ID), start, end)]
+    created <= start & scraped >= end]$property_ID), start, end, 
+    # SIMPLIFY = FALSE in case of one-row output
+    SIMPLIFY = FALSE)]
 
   date_table <- date_table[lengths(PID) >= min_listings]