Repository navigation
Resolve Groundwork styles from the installed peer dependency - #352
Merged
Merged
Conversation
LaurenAllin
approved these changes
Sep 30, 2026
LaurenAllin
left a comment
Collaborator
There was a problem hiding this comment.
Changes seem to be working as expected. Noticed some other styling issues where components overlay the site-wrapper header. This shows up in the prod version of groundwork-water docs, however, so this is a separate issue.
Contributor
Author
|
Should be fixed with #353 I had to run the manual deploy of the site this morning after we chatted! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went ahead and hotfixed the current overlap issue GWW had on the github pages site with
#353
This PR solves the larger issue of downstream repos needing to import both groundwork and style.css by bundling the two togetehr and only requiring you install the groundwork-water css exposed file. (See docs in PR changes)
Changes
/style.cssand/dist/style.cssand remove the separate docs import.^4.3.2compatibility. Add packed-consumer checks for Groundwork 4 and React 18/19.Testing
/docs, plus a fixture search insideSiteWrapper, passed desktop/mobile checks at 1440px and 390px. Verified search empty/results states and header stacking after scrolling.git diff --check: passed. Builds retain configuration, icon asset, directive, and bundle warnings. No deployed-site testing performed.