Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for 5.3.0 release #179

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft

PR for 5.3.0 release #179

wants to merge 31 commits into from

Conversation

cbuahin
Copy link
Collaborator

@cbuahin cbuahin commented Jun 3, 2024

No description provided.

@LRossman
Copy link
Collaborator

LRossman commented Jun 3, 2024

@cbuahin I'm happy to see you are making progress on pushing out a version 5.3. I was hoping it would include the improvements to how submerged inlets are handled as described in issue #139 and implemented in the the inlet_improvement branch. As I didn't see it included on this set of commits I'm hoping you will eventually add it to the v5.3 pipeline since it provides a more physically realistic way of modeling sewer overflow onto the street than does the current method used in v5.2.4.

@michaeltryby
Copy link
Collaborator

Great work @cbuahin!

@cbuahin
Copy link
Collaborator Author

cbuahin commented Jun 3, 2024

@LRossman, thanks for the reminder. There are a couple more issues to address as part of this release. I will work on bringing in the solution you provided for #139 as part of that work.

@jubilee2
Copy link

jubilee2 commented Jun 8, 2024

can you include this update for #168 (comment)

@cbuahin
Copy link
Collaborator Author

cbuahin commented Jun 13, 2024

@jubilee2 , yes, #168 is one of the issues we are addressing for v5.3.0. You can check the issues for the v5.3.0 milestone here

@jubilee2
Copy link

@jubilee2 , yes, #168 is one of the issues we are addressing for v5.3.0. You can check the issues for the v5.3.0 milestone here

Thank you

@MdoubleDash
Copy link

@cbuahin, appreciate your efforts. Do you have any plans for addressing lower priority enhancements/issues such as #171?

@cbuahin cbuahin added this to the v5.3.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants