Skip to content

Commit

Permalink
CRAN submission
Browse files Browse the repository at this point in the history
  • Loading branch information
jhollist committed Jun 12, 2023
1 parent ef3388c commit ce5cdf8
Showing 1 changed file with 5 additions and 14 deletions.
19 changes: 5 additions & 14 deletions cran_comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
## Comments
- Re-submit (SORRY!) with fixed URLS
- Changed API ERRORS to messages and return NA or NULL. Would bomb out runs when this would happen only occasionally. Also this should meet CRAN policy on failing gracefully.
- Switched long lat check to st::sf_is_longlat
- Fixed EPQS API URL that was poitned out by a user and emails from Uwe Ligges and Brian Ripley on 2023-05-26.

- Added startup message indicating upcoming change to sf and terra in future releases.

## Test Environments

- Github Actions, Ubuntu 20.04.6 LTS, R version 4.3.0
- Github Actions, Ubuntu 20.04.6 LTS, R version 4.2.3
- Github Actions, Ubuntu 22.04.2 LTS, R development
Expand All @@ -14,17 +13,9 @@
- Local, Windows 10 x64 (build 19042), R version 4.2.2

## R CMD check results

- No ERRORS or WARNINGS

## revdepcheck results

We checked 9 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 1 packages

Issues with CRAN packages are summarised below.

### Failed to check

* shoredate (NA)
Reverse dependencies were checked with release 0.4.4 on May 31, 2023. They have not changed since and this release is minor and they were not checked again.

0 comments on commit ce5cdf8

Please sign in to comment.