Add new get_elev_profile() function + minor clean-up/refactor
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add coords and elev_col arguments to loc_check to support custom coordinate values or elevation column values - Add loc_length helper - Also improve support for sfg input objects - Correct outdated function title
- Add support for custom coords value to `get_elev_raster()` - Add support to `get_elev_point()` for custom elevation column and elevation units column name - Add support for custom elevation column value to `get_epqs()` and `get_aws_points()` - Add support for custom units values beyond meters and feet - Remove trailing spaces (automatic in RStudio - hope it doesn't clutter the commit too badly!)
- Update docs based on cleaned up whitespace - Add optional support for markdown formatted Roxygen
Also cleans up whitespace automatically
- Simplify internal logic - Fix leftover use of ll_geo for crs instead of prj
Function wraps `get_elev_point()` to add support for returning elevation along a profile line
Also fill missing argument definition for loc_check
Fill missing argument definitions for get_elev_point
Second try!
Also wrap example in don't run tag
Tidy DESCRIPTION
|
Thanks! I commented on #93 |
|
Thanks! I'll add some new tests and trouble-shoot any other outstanding issues in the next week or two. Even if |
Also update get_elev_raster to use terra:rast if raster package is not installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_profile_elev()function for returning elevation along a line #93get_elev_profile()functionTests for
get_elev_profile()still need to be added.