Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved .download functions to .db #115

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

MJWeberg
Copy link
Collaborator

Phase 2 of search and download refactor. Mostly internal changes that should be invisible to general users.

Summary of changes

  • Moved download_db() and download_hd5f_data() from eispac.download to eispac.db
  • Moved low-level time conversion functions (tai2utc and utc2tai) from eispac.download.convert to eispac.util.convert
  • Replaced calls to the old EIS_DB class with EISAsRun in the eis_catalog GUI
  • Added pass-through functions to eispac.download for the moved functions and added deprecation warnings. Very few (if any) users will see these warnings since no one was likely calling these functions directly.
  • Small update to the API documentation (may take a while before ReadTheDocs updates)
  • Assorted very minor bug-fixes

@MJWeberg MJWeberg added bug Something isn't working code cleanup labels Feb 27, 2025
@MJWeberg MJWeberg self-assigned this Feb 27, 2025
@MJWeberg MJWeberg merged commit c870cda into USNavalResearchLaboratory:main Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant