Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUP 55 - Create Event Page #229

Merged
merged 5 commits into from
May 8, 2024
Merged

JUP 55 - Create Event Page #229

merged 5 commits into from
May 8, 2024

Conversation

BK2004
Copy link
Contributor

@BK2004 BK2004 commented May 7, 2024

  • Created event page under /manage/[clubId]/create
  • Added router procedure for creating events
  • Create page has a preview of user event

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 6:50pm

Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good overall. Only changes I can see is having either a success toast message whenever an event has successfully been created or redirect them to the new event page

>
{event.club.name}
</p>
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a bit more vertical space between the time and club name to make the card less empty

}, [router, watch, officerClubs]);

const createMutation = api.event.create.useMutation({
onSuccess: () => { location.reload(); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On success either show a success message or redirect to the event page using Router.push

@RubenOlano RubenOlano merged commit 1aee81e into develop May 8, 2024
3 checks passed
@RubenOlano RubenOlano deleted the JUP-55 branch May 8, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants