fix: update ortools and add e2e test for validation error #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akevinge
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Looks good overall.
Could you update the python version in some of the workflows?
planner/.github/workflows/validator_test.yml
Lines 20 to 22 in 40e9371
planner/.github/workflows/tests.yml
Lines 75 to 78 in 40e9371
akevinge
requested review from
akevinge
and removed request for
Peytonbarre
|
Closing, same PR here: #666. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #660