Fixed Join/Joined button flicker during state transitions #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaivishaalSureshkannan
requested review from
BK2004 and
Shivhare-Ayush
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
Member
|
This works great! Can you do the same thing on the |
Contributor
Author
|
Hi, I was able to fix the button flicker on the register button on the event section as well. |
TyHil
approved these changes
Dec 27, 2025
Member
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
This looks great! Lmk if you're ready to merge
Contributor
Author
|
Thanks for the review. I am ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Join club and Register event transitioning #453
Problem:
The Join/Joined button reverted to its previous label after loading for a brief time period. I believe this is happening due to the stale React query data during refetching. This causes the component to render again using that stale value, resulting in temporary reappearance of the initial label.
Join -> Loading -> Join -> Joined
Joined -> Loading -> Joined -> Join
Solution:
I was able to implement an optimistic UI state for the join button. The button label updates immediately on click by the user and while that action is pending, the UI reflects the expected next state. If there is error, the UI will roll back. This removes that flicker.
Testing: