Basic System Manager #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aidan-B
requested changes
Jul 29, 2023
SystemManager/Src/SystemManager.cpp
Outdated
| this->throttleMotorChannel_.set(rcInputs_.throttle); | ||
| this->yawMotorChannel_.set(rcInputs_.yaw); | ||
| this->rollMotorChannel_.set(rcInputs_.roll); | ||
| this->pitchMotorChannel_.set(rcInputs_.pitch); |
There was a problem hiding this comment.
2 notes
- This assumes we only have 1 motor per axis, which wont be true for a plane. We will likely have 2 motors for roll.
- There is no provision here for arm/disarm. The throttle motor will spin up if the throttle stick on the controller is bumped, and is not safe at all. (this is something that happens all the time, please add an arm/disarm check. Typically you can only arm if the throttle is down and a switch is hit.)
There was a problem hiding this comment.
- I believe for M1 I was asked to assume that each axis has its own motor.
- Just added a provision to check for arm/disarm
There was a problem hiding this comment.
I can say with near certainty that you will need to add a second motor for the roll axis that is inverted (1 motor per aileron)
Aidan-B
previously requested changes
Aug 3, 2023
antholuo
reviewed
Aug 14, 2023
antholuo
reviewed
Aug 14, 2023
- Added a function to RCControls struct to assign values from an existing object - Implemented basic SBUS input taking with SM - Updated CMAKE
- IWDG timeout is set to 1 second - Added MotorChannel drivers to CMake
TheSpaceDragon
force-pushed
the
basic-system-manager
branch
from
df7c938
to
4b40609
Compare
SnackkOverflowError
approved these changes
Nov 2, 2023
Chrisc110
approved these changes
Nov 16, 2023
Co-authored-by: Anthony Bertnyk <[email protected]> Co-authored-by: TheSpaceDragon <[email protected]> Co-authored-by: Navtaj Hundal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What was completed, changed, or updated?
Basic System Manager is now complete!! This manager now takes input and executes them on motor outputs in an infinite loop. All that is needed to be done is instantiation and the call of the function,
flyManually().Why was this done (if applicable)?
N/A
Testing
What manual tests were used to validate the code?
Need help with on-site members with testing :p
What unit tests were used to validate the code?
To be written...
Documentation
Milestone 1: Manual Fixed Wing
Link to Asana task:
https://app.asana.com/0/1203458353737758/1204799650722171
Reminders
Add reviewers to the PR
Mention the PR in the appropriate discord channel