MS5611 Driver Update #2 #53
Conversation
…nce with spi handler and cs/ps port and pins
…1 class, and more descriptive naming for MS5611 calibration coefficients
…iption formatting on calculateTempPres() function
…led in getPressure() and getTempemrautre() functions
…on hierarchy structure
| HAL_GPIO_WritePin(cs_port_, cs_pin_, GPIO_PIN_SET); | ||
|
|
||
| // construct 16-bit calibration coefficient. | ||
| uint16_t prom_element = ((rx_data[1] << 8) | (rx_data[2])) & 0x0000FFFF; |
There was a problem hiding this comment.
This mask 0x0000FFFF has a size of 32 bits which is confusing here since prom_element has only a size of uint16_t.
|
|
||
| uint8_t tx_data = conversion_command; | ||
| uint8_t rx_data; | ||
| uint8_t tx_data_2[4] = {ADC_READ, 0xFF, 0xFF, 0xFF}; |
There was a problem hiding this comment.
Looks like this can be a const. Same with the other tx_data.
| HAL_GPIO_WritePin(cs_port_, cs_pin_, GPIO_PIN_RESET); | ||
|
|
||
| // send the digital pressure or temperature with the command. | ||
| HAL_StatusTypeDef spi_status_ = HAL_SPI_TransmitReceive_IT(spi_handle_, &tx_data, &rx_data, data_size); |
There was a problem hiding this comment.
Sorry, it was me in the previous PR saying maybe we could use interrupt-based data transceiving in the future, but I actually meant using DMA. And here I think it makes sense to use normal polling since you are reading the transmitting at the same time. I thought if you call the hal function ended with _IT, you are also triggering an ISR callback function, but you also don't need to use it here, so there is not a big difference between using interrupt base or pulling based transceiving.
Description
What was completed, changed, or updated?
Update of MS5611 Driver. Function return types changed from bool to float with FLT_MAX used to signify errors. Communication_success_ internal variable removed and replaced with other internal variables.
Temperature, pressure and altitude values were printed to the UART. For the altitude, the barometer was raised a few meters and measurements were observed. For temperature, values were compared to local thermometer. The pressure was compared to the pressure of the city I was in (googled).
Testing
What manual tests were used to validate the code?
What unit tests were used to validate the code?
Reminders
Add reviewers to the PR
Mention the PR in the appropriate discord channel