IMU ICM42688 Driver #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created cpp and header files for the ICM42688. Code has been structured from the tested code found at https://github.com/UWARG/efs-kitchen-sinks/blob/main/icm42688.zip
- Implemented a constructor to take in SPI_HANDLE, GPIO PORT, and CS_PIN - Moved some methods to private for abstraction - Used new defines to reduce magic numbers
Altered cmakelist to support compilation
antholuo
approved these changes
Oct 31, 2024
Drivers/imu/inc/icm42688.hpp
Outdated
|
|
||
| //Variables used in gyro calibration | ||
| float gyro_scale = 0; | ||
| uint8_t current_fssel = 0; |
There was a problem hiding this comment.
I have renamed it in the latest commit
Drivers/imu/src/icm42688.cpp
Outdated
| void ICM42688::calibrate() { | ||
| //Set at a lower range (more resolution since IMU not moving) | ||
| const uint8_t current_fssel = gyroFS; | ||
| setGyroFS(0x03); //Set to 250 dps |
There was a problem hiding this comment.
magic number 0x03. Should this be a #define or constexpr?
There was a problem hiding this comment.
Ah thanks, you're right; I changed it to be a #define in the latest commit.
IMU Driver restructured with a virtual class header file, actual driver header file, and driver code. Implemented code to calibrate, read, and process data from a 6-axis IMU
HardyYu
reviewed
Nov 6, 2024
Modified member variable names to align with the WARG naming convention
Created cpp and header files for the ICM42688. Code has been structured from the tested code found at https://github.com/UWARG/efs-kitchen-sinks/blob/main/icm42688.zip IMU Driver has been restructured with a virtual class header file, actual driver header file, and driver code. - Implemented a constructor to take in SPI_HANDLE, GPIO PORT, and CS_PIN - Implemented code to calibrate, read, and process data from the 6-axis IMU - Altered cmakelist to support compilation
HardyYu
approved these changes
Nov 9, 2024
…ropilot-3.5 into IMU-ICM42688-Driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What was completed, changed, or updated?
The ICM Driver (previously created, tested, and stored in https://github.com/UWARG/efs-kitchen-sinks/blob/main/icm42688.zip) has been restructured into a virtual class header file, the actual driver header file, and the driver code. Refer to this original PR for comments: #62
Why was this done (if applicable)?
This was done to leave the option for the flight controller to initiate a different imu hardware driver or run a mock imu class for unit test purposes
Testing
What manual tests were used to validate the code?
Functionality was validated with the original code on an STM board, where accelerometer and gyroscope data were successfully read from the IMU. The accuracy of accelerometer data was determined by testing for a 1g reading on each axis. The accuracy of gyroscope data was determined by temporarily implementing sensor fusion to obtain angles, from which the angles were validated.
Note: Testing for the code in this PR has not been done; only for the code in kitchensinks
What unit tests were used to validate the code?
N/A
Documentation
Milestone number and name:
M3
Link to Asana task:
https://app.asana.com/0/1203458353737758/1204645027312230
Link to Confluence documentation:
N/A