Add isolated CI coverage for extras and guard optional-dependency tests#895
Merged
Conversation
Collaborator
Author
|
codex
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
This follows the dependency mismatch discussed in #855 and fixed in #856.
That issue was easy to miss because CI mainly exercised an all-extras environment. In that setup, dependencies installed by one extra can mask missing dependencies in another extra. In the
faster-whispercase,soundfilecould be present because of other installs, so thefaster-whisperpackaging contract was not being verified in isolation.What This Changes
basejob that installs only.[dev]extra-contractsjobs that create a fresh environment per extra and run targeted verificationTesting
git diff --checkpython3 -m compileall tests speech_recognitionA full local pytest run in a fresh CI-like environment was not possible from this worktree, so the new workflow is intended to validate the matrix in CI.