Fix switch toggle UI updates and subtitle selection in player settings menu#252
Draft
Fix switch toggle UI updates and subtitle selection in player settings menu#252
Conversation
Co-authored-by: UcnacDx2 <127503808+UcnacDx2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix subtitle options behavior in player settings
Fix switch toggle UI updates and subtitle selection in player settings menu
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "More Options" menu had two issues: switches (高能进度条, 弹幕) didn't update UI on toggle, and the subtitle option opened a settings dialog instead of a direct selection menu like playback speed.
Changes
SwitchListTileinObx: Enables reactive UI updates when GetX observable values changeAdded
showSelectSubtitle()method: Displays bottom sheet with direct subtitle selection (关闭字幕 + available subtitles), matching the pattern ofshowSetSpeed()and the player controls subtitle button (view.dart:660)Updated subtitle menu item: Now calls
showSelectSubtitle()for immediate selection instead ofshowSetSubtitle()which opens a styling settings dialogOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.