Skip to content

Conversation

@uipreliga
Copy link
Collaborator

This pull request introduces a shared validation utility for pagination parameters, refactors existing services to use it, and adds comprehensive tests to ensure consistent pagination and bulk job operations. The changes improve code reuse, maintainability, and reliability of pagination and job resolution logic across the SDK.

Shared validation utility:

  • Added a new validate_pagination_params function in src/uipath/_utils/validation.py to centralize and standardize pagination parameter checks for SDK services.
  • Exposed validate_pagination_params in the public API via src/uipath/_utils/__init__.py. [1] [2]

Service refactoring for pagination validation:

  • Refactored BucketsService.list and BucketsService.list_async methods to use the shared validate_pagination_params utility instead of inline checks, ensuring consistent validation logic. [1] [2] [3]

Testing improvements:

  • Added extensive tests for the new validation utility in tests/sdk/test_utils_validation.py, covering edge cases and boundary values.
  • Added a fixture for JobsService to support new and existing tests in tests/sdk/services/conftest.py.

JobsService enhancements and testing:

  • Added tests for bulk job operations and N+1 query fix in tests/sdk/services/test_jobs_service_bulk_operations.py, ensuring efficient job resolution and correct API usage.
  • Added tests for pagination behavior and validation in JobsService with tests/sdk/services/test_jobs_service_pagination.py, verifying correct paged results and validation error handling.

@github-actions github-actions bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository labels Nov 20, 2025
@uipreliga uipreliga force-pushed the feat/jobs-service-enhancements branch from a126659 to 451c231 Compare December 5, 2025 17:38
@uipreliga uipreliga merged commit 8d52109 into main Dec 5, 2025
67 checks passed
@uipreliga uipreliga deleted the feat/jobs-service-enhancements branch December 5, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants