Implement exclusive relationships #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be more optimal if you just pass the entity into where the archetype graph is involved and invoke an on_remove hook when necessary. |
|
Good idea. |
Ukendio
requested changes
Apr 4, 2025
| on_remove(entity) | ||
| end | ||
| end | ||
|
|
||
| -- If there was a previous archetype, then the entity needs to move the archetype | ||
| entity_move(entity_index, entity, record, to) |
There was a problem hiding this comment.
It has to be record.archetype since on_remove can change the archetype it is destined for.
| @@ -945,6 +975,13 @@ local function world_set(world: ecs_world_t, entity: i53, id: i53, data: unknown | |||
| end | |||
|
|
|||
| if from then | |||
| if ECS_IS_PAIR(id) and bit32.band(idr.flags, ECS_ID_EXCLUSIVE) ~= 0 then | |||
There was a problem hiding this comment.
it is probably cheap enough to just check the flags, you can benchmark and confirm.
But if you want to check if it is a pair first, you should only look up the id_record if the id is a pair.
| on_remove(entity) | ||
| end | ||
| end | ||
|
|
||
| entity_move(entity_index, entity, record, to) |
There was a problem hiding this comment.
has to be record.archetype not to because on_remove can cause the entity to move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements exclusive relationships following flecs' implementation.
For some unknown reason the "#repro2" test now fails. Removing the
world:set(entity, pair(4, 5), 6)call at line 145 fixes it.