Closed
Conversation
|
jswhit2 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
Author
|
FYI this did not help #379. See my test where I tried both changes in https://github.com/ocefpaf/cftime/actions/runs/22368151216/job/64739567532 |
Comment on lines
12
to
16
| # Cython 3.0.0 changes the default of the c_api_binop_methods directive to | ||
| # False, resulting in errors in datetime and timedelta arithmetic: | ||
| # https://github.com/Unidata/cftime/issues/271. We explicitly set it to | ||
| # True to retain Cython 0.x behavior for future Cython versions. This | ||
| # directive was added in Cython version 0.29.20. |
Contributor
There was a problem hiding this comment.
I think most if not all of this comment could be removed if you're requiring Cython>=3.0 now
Contributor
Author
Collaborator
There was a problem hiding this comment.
if this doesn't fix #372, I don't think there is any reason to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fix #379 and unlocks #372.