Use SNMPv3 contexts for collecting logical BRIDGE-MIB instances (primarily Cisco) #3668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunkwill42
added
cisco
snmpv3
nonews
Base automatically changed from
refactor/multibridgemib-inlinecallbacks
to
master
December 5, 2025 13:28
lunkwill42
force-pushed
the
feature/snmpv3-multibridgemib-contexts
branch
from
e870583 to
0feea79
Compare
lunkwill42
changed the title
Henceforth, a logical MIB instance identifier may also include an optional SNMPv3 context name, and an optional context engine ID, if such things were discovered. Since a community value makes no sense for SNMPv3 communication, the community field should also be optional.
Some code still expected a BRIDGE-MIB instance descriptor to be a two-tuple value, but should really produce LogicalMibInstance named tuples.
We need to fetch context name and context engine ID values from logical MIB instances to know how to configure our SNMPv3 requests to fetch these logical instances.
In order to support SNMPv3 contexts, this adds `context_name` and `context_engine_id` as optional attributes on SNMPParameters objects, and ensures the correct Net-SNMP command line arguments are generated for them.
Making alternate agent proxy instances need to consider which SNMP version is represented, as changing the community makes no sense on SNMPv3 sessions, while changing context name (and optionally adding a context engine id) does. It's also easier and more portable to manipulate parameters selectively by modifying the `snmp_parameters` of the existing session: That way, all other parameters of the session are carried through to the alternate agent proxies.
Only care about debug logging that we got results from alternate agent proxies, as timeouts would be silently ignored.
lunkwill42
force-pushed
the
feature/snmpv3-multibridgemib-contexts
branch
from
0feea79 to
6c555bb
Compare
|
Test results 14 files 14 suites 13m 17s ⏱️ For more details on these failures, see this check. Results for commit 6c555bb. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3668 +/- ##
==========================================
- Coverage 62.94% 62.73% -0.22%
==========================================
Files 611 612 +1
Lines 45145 45172 +27
Branches 43 43
==========================================
- Hits 28417 28339 -78
- Misses 16718 16823 +105
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #2811. Dependent on #3664.
This is still a work in progress, since I'm not yet able to confirm this functionality with real devices due to potential SNMPv3 authorization issues with test equipment.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.