Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
src/utility/UtilityLib.sol
Outdated
|
|
||
| /// @notice Returns the users balance only if reentrancy protection is not active on the Compact. This eliminates in flight balances before the ERC6909 tokens were burned. | ||
| /// @dev Only if eip-1153 (transient storage) is not available. | ||
| function settledBalanceOf_nonTransient(address owner, uint256 id) internal view returns (uint256 amount) { |
There was a problem hiding this comment.
for this one, if we want to go try-hard on it we could derive the balance slot and use the batch extsload function to get both values in one call
There was a problem hiding this comment.
I like it! Not sure how much more efficient this will be though? it will at least lead to higher revert costs, since both values will be read from storage not knowing, if we even need the balance.
0age
left a comment
0age
left a comment
There was a problem hiding this comment.
looking good! left some comments, the major thing i think this is still missing is a helper function for handling the case where tstore isn't supported yet but may become supported, and probably also a helper that makes it dead-simple for integrators (basically giving them a "settledBalanceOf" function that will select the appropriate function under the hood)
effectively, you'd have:
- logic in the constructor to check if tstore is supported (which already has a helper implemented) and if so just assign the current settledBalanceOf as the balance check fn from the get-go
- logic in the alternative balance check contract to handle cases where tstore got activated at a later point; I feel like the most straightforward move here is to just read both the tstore slot and the sstore slot and if either is set to revert (IMHO you'd be hard-pressed to find a chain that doesn't support tstore yet where execution isn't dirt-cheap)
| pop(staticcall(gas(), THE_COMPACT, 0x1c, 0x24, 0, 0x20)) | ||
| reentrancySlotContent := mload(0) | ||
|
|
||
| // We do not need to check for success. |
There was a problem hiding this comment.
Tiny nit on comments: the convention is to avoid "we" and instead just be declarative / talk about what is happening
| revert BalanceNotSettled(); | ||
| } | ||
|
|
||
| // If we get here, the balance is settled, so returning the balance |
3 participants
Added the UtilityLib:
settledBalanceOfto retrieve an ERC6909 balance from the compact. The function reverts in case the compacts reentrancy guard is active.