Skip to content

Changes for using UTBotCPP on scalapack project. #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 15, 2022
Merged

Conversation

kichunya
Copy link
Collaborator

@kichunya kichunya commented Dec 2, 2022

This PR fixes several problems that appeared on the project scalapack:

  1. Avoid .f and .f.o files as source files.
  2. Use definition parameters (cause due to "extern func();" declaration function`s parameters were lost)
  3. Fix wrong test header and wrapper printing due to old style function definition.

@kichunya kichunya linked an issue Dec 2, 2022 that may be closed by this pull request
return result;
}

bool SourceToHeaderMatchCallback::IsOldStyleDefinition(std::string const &definition) const{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with example

@@ -164,6 +171,9 @@ void ProjectBuildDatabase::initInfo(const nlohmann::json &linkCommandsJson) {
for (nlohmann::json const &jsonFile: linkCommand.at("files")) {
auto filename = jsonFile.get<std::string>();
fs::path currentFile = Paths::getCCJsonFileFullPath(filename, command.getDirectory());
if (currentFile.string().substr(currentFile.string().size() - 4) == ".f.o"){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this check to a separate function to add other unsupported files in future

@kichunya kichunya requested a review from ladisgin December 14, 2022 12:26
@kichunya kichunya merged commit e8a5e79 into main Dec 15, 2022
@sava-cska sava-cska deleted the kichunya/scalapack branch December 19, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UTBot cannot run test for old-style declared function
2 participants