Support custom EtsStmt in CFG DSL#347
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom EtsStmt statements in the CFG (Control Flow Graph) DSL by introducing a new CustomEts node type and its corresponding block and statement representations. This allows users to define custom ETS statements directly in the DSL that are converted to native EtsStmt objects during compilation.
Key changes:
- Introduces new
CustomEts,BlockCustomEts, andCustomEtsStmtclasses to represent custom statements - Adds support for custom statements throughout the DSL pipeline (Program → BlockCfg → LinearizedCfg)
- Updates visualization methods to handle the new custom statement types
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Node.kt | Adds CustomEts node class with toEts function parameter |
| BlockStmt.kt | Adds BlockCustomEts block statement representation |
| Stmt.kt | Adds CustomEtsStmt linearized statement representation |
| ProgramBuilder.kt | Adds customStmt method to program builder interface and implementations |
| BlockCfg.kt | Maps CustomEts nodes to BlockCustomEts statements |
| LinearizedCfg.kt | Converts BlockCustomEts to CustomEtsStmt and fixes return statement validation |
| BlockCfgBuilder.kt | Handles BlockCustomEts statements in ETS compilation |
| ToDot.kt | Adds placeholder labels for custom statements in DOT visualization |
| Program.kt | Adds custom statement handling in string representation |
| DSL.kt | Provides example usage of the new custom statement feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CaelmBleidd
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.