Conversation
Lipen
commented
Apr 16, 2025
CaelmBleidd
requested changes
Apr 17, 2025
CaelmBleidd
approved these changes
Apr 17, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| // TODO hack because of an issue with signatures | ||
| private val compareByMethodNameAndEnclosingClass = { fst: EtsMethod, snd: EtsMethod -> | ||
| fst.name === snd.name && fst.enclosingClass.name === snd.enclosingClass.name | ||
| fst.name === snd.name && fst.signature.enclosingClass.name === snd.signature.enclosingClass.name |
Check warning
Code scanning / detekt
Avoid using referential equality and prefer to use referential equality checks instead. Warning test
| // TODO hack because of an issue with signatures | ||
| private val compareByMethodNameAndEnclosingClass = { fst: EtsMethod, snd: EtsMethod -> | ||
| fst.name === snd.name && fst.enclosingClass.name === snd.enclosingClass.name | ||
| fst.name === snd.name && fst.signature.enclosingClass.name === snd.signature.enclosingClass.name |
Check warning
Code scanning / detekt
Avoid using referential equality and prefer to use referential equality checks instead. Warning test
Saloed
pushed a commit
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the necessary fixes by incorporating the changes in ETS model introduced by UnitTestBot/jacodb#313.