Skip to content

fix: Avoid throwing exception when using NetworkList without a NetworkManager [Up-port] #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NoelStephensUnity
Copy link
Collaborator

Up-port of #3502
Fixes #2539

Changelog

  • Added: LocalClientCannotWrite function to co-locate the shared functionality
  • Fixed: Ensure that the NetworkManager exists before attempting to access the LocalClientId

Testing and Documentation

  • No tests have been added.

Backport

Backported in #3502

unity-renovate bot and others added 4 commits June 13, 2025 16:43
…(develop-2.0.0) (#3499)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| RecipeEngine.Modules.Wrench | nuget | patch | `0.11.2` -> `0.11.3` |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Unity Renovate
Bot](https://internaldocs.unity.com/renovate/).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIwLjAuMC1zZW1hbnRpYy1yZWxlYXNlIiwidXBkYXRlZEluVmVyIjoiMC4wLjAtc2VtYW50aWMtcmVsZWFzZSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AtMi4wLjAiLCJsYWJlbHMiOltdfQ==-->

## Backport

#3498

Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com>
Some missed parenthesis addition and removal.
EmandM and others added 3 commits June 13, 2025 17:51
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review June 13, 2025 21:58
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 13, 2025 21:58
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) June 13, 2025 21:58
Missing encapsulated Boolean check.
@NoelStephensUnity NoelStephensUnity merged commit 7bbc1c3 into release/2.4.2 Jun 14, 2025
33 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/2.x/network-manager-exception-2-4-2 branch June 14, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants