[NoelStephensUnity]

Purpose of this PR

Removing GhostObject or NetworkObject from a hybrid prefab now leaves a clean prefab, without the hidden NetworkObjectBridge left behind.

Removing GhostObject: the pre-removal callback now removes only the NetworkObjectBridge and any GhostRigidbody, and SynchronizeTransform is enabled again. Previously it destroyed every GhostBehaviour on the prefab, including user scripts.

Removing NetworkObject: the NetworkObjectBridge now removes itself when its NetworkObject is gone.

In-scene placed hybrid instances: the GhostObject is now removed through the same path, so the bridge is removed with it.

The bridge also now sets FullTickSmoothing in place of the obsolete SingleWorldHostInterpolationSmoothing.

PR Scope:

• Editor-time hybrid prefab authoring in NetworkObject, NetworkObjectEditor and NetworkObjectBridge.

Out of scope:

• Removing user GhostBehaviours when GhostObject is removed (they belong to the user).
• Undoing the N4E-side GhostRigidbody / replicate-rigidbody settings when GhostObject is removed (N4E owns those).

Jira ticket

N/A

Changelog

None (hybrid prefabs require an unreleased N4E version).

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

• Manual testing done: add and remove GhostObject and NetworkObject on a hybrid prefab in the inspector, and toggle the Networked checkbox.

Automated tests:

• Covered by existing automated tests
• Covered by new automated tests

Does the change require QA team to:

• Review automated tests?
• Execute manual tests?
• Provide feedback about the PR?

Up-port

Not needed: hybrid prefabs are NGO 3.x only.

Backports

Not needed: hybrid prefabs are NGO 3.x only.

[u-pr]

💡 Harness Review

The cleanup now targets bridge components more precisely, but component removal and serialized hybrid state need to remain consistent.

_{Reviewed commit 472ba7f}

_{🤖 Helpful? 👍/👎}

[NoelStephensUnity]

@u-pr please review again

[u-pr]

Here is a summary of findings from reviewing the updated changes:

1. GhostObject Reference Cleanup

Commit e81a81c added HasGhost = false to OnRemoveNetworkObjectBridge(), which clears the hybrid flag. However, networkObject.GhostObject is still not cleared in OnGhostObjectPreRemoval. When the GhostObject component is deleted in the Inspector, leaving networkObject.GhostObject uncleared leaves a dangling/missing component reference on the NetworkObject (which persists in serialized prefab assets). Restoring networkObject.GhostObject = null; in OnGhostObjectPreRemoval ensures the field is cleanly reset.

2. Bridge Component Detection in UnifiedValidation

In NetworkObject.UnifiedValidation:

else if (HadBridge && !HasGhost)
{
    if (NetworkObjectBridge != null)
    {
        EditorApplication.update -= OnRemoveNetworkObjectBridge;
        EditorApplication.update += OnRemoveNetworkObjectBridge;
    }
    else
    {
        HadBridge = false;
        SynchronizeTransform = true;
    }
}

If the NetworkObjectBridge field is null (such as after a domain reload or if the serialized reference was lost), but the NetworkObjectBridge component is still present on the GameObject, the check NetworkObjectBridge != null evaluates to false. This triggers the else block, resetting HadBridge = false and leaving the bridge component behind. Checking if (NetworkObjectBridge != null || GetComponent<NetworkObjectBridge>() != null) avoids orphaning the component.

3. Null Safety and Unregistration Order for EditorApplication.update Callbacks

In OnRemoveNetworkObjectBridge, OnAddNetworkObjectBridge, and OnRemoveGhostObject, unregistering (EditorApplication.update -= ...) occurs at the end of each method:

• If the target NetworkObject or GameObject is destroyed between being scheduled and the update tick running, accessing gameObject throws a MissingReferenceException.
• Because the exception occurs before reaching the unsubscription line, the delegate remains subscribed and will throw MissingReferenceException repeatedly on every editor update frame.

Unregistering at the start of each callback and checking if (this == null) return; ensures that callbacks are cleanly removed even if the object was destroyed in the meantime.

_{🤖 Helpful? 👍/👎}

[u-pr]

💡 Harness Review

The cleanup and delayed validation address the hybrid-state lifecycle, but rebuilding the bridge can overwrite a user-authored prediction setting.

_{Reviewed commit a182f27}

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 1.88679% with 52 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
....netcode.gameobjects/Runtime/Core/NetworkObject.cs	2.00%	49 Missing ⚠️
.../Runtime/Components/Helpers/NetworkObjectBridge.cs	0.00%	3 Missing ⚠️

@@                Coverage Diff                @@
##           develop-3.x.x    #4211      +/-   ##
=================================================
- Coverage          76.03%   75.88%   -0.15%     
=================================================
  Files                159      159              
  Lines              27344    27402      +58     
=================================================
+ Hits               20791    20795       +4     
- Misses              6553     6607      +54     

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	74.94% <1.88%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../Runtime/Components/Helpers/NetworkObjectBridge.cs	0.00% <0.00%> (ø)
....netcode.gameobjects/Runtime/Core/NetworkObject.cs	72.24% <2.00%> (-1.58%)	⬇️

... and 1 file with indirect coverage changes

Components	Coverage Δ
com.unity.netcode.gameobjects	75.88% <19.67%> (-0.15%)	⬇️

ℹ️ Need help interpreting these results?