Skip to content

Making some Types and Properties public to allow building of custom tools with it #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Making some Types and Properties public to allow building of custom tools with it #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa0c524
MeshSelection.totalVertexCountOptimized
CortiWins Oct 12, 2025
d42e82b
CutTool made public
CortiWins Oct 12, 2025
0c73a20
PositionToolContext |TextureToolContext made public
CortiWins Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Changes
- PositionToolContext made public
- TextureToolContext made public
- MeshSelection.totalVertexCountOptimized made public
- CutTool made public

### Fixed

- [PBLD-240] Fixed a bug where buttons for "Create Cube" and "Create PolyShape" appeared incorrectly on Light theme.
Expand Down
2 changes: 1 addition & 1 deletion Editor/EditorCore/CutTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
namespace UnityEditor.ProBuilder
{
[EditorTool("Cut Tool", typeof(ProBuilderMesh), typeof(PositionToolContext))]
class CutTool : EditorTool
public class CutTool : EditorTool
{
ProBuilderMesh m_Mesh;

Expand Down
7 changes: 5 additions & 2 deletions Editor/EditorCore/MeshSelection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,11 @@ internal static bool Contains(ProBuilderMesh mesh)
/// Gets the number of all selected vertices across the selected ProBuilder meshes, excluding coincident duplicates.
/// </summary>
public static int totalCommonVertexCount { get { CacheElementCounts(); return s_TotalCommonVertexCount; } }

internal static int totalVertexCountOptimized { get { CacheElementCounts(); return s_TotalVertexCountCompiled; } }

/// <summary>
/// Gets the number of all selected ProBuilder compiled mesh vertices.
/// </summary>
public static int totalVertexCountOptimized { get { CacheElementCounts(); return s_TotalVertexCountCompiled; } }

/// <summary>
/// Gets the sum of all selected ProBuilderMesh faces.
Expand Down
4 changes: 2 additions & 2 deletions Editor/EditorCore/ProBuilderToolsContexts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ static class ProBuilderToolManager

[Icon("Packages/com.unity.probuilder/Content/Icons/EditableMesh/EditMeshContext.png")]
[EditorToolContext("ProBuilder", typeof(ProBuilderMesh))]
class PositionToolContext : EditorToolContext
public class PositionToolContext : EditorToolContext
{
internal class ProBuilderShortcutContext : IShortcutContext
{
Expand Down Expand Up @@ -407,7 +407,7 @@ static void SetColliderAction(MenuCommand command)
}
}

class TextureToolContext : EditorToolContext
public class TextureToolContext : EditorToolContext
{
ProBuilderEditor m_Editor;

Expand Down