Repository navigation
Let typos accept the renamed Noto Sans font file - #10
Draft
francois-unity wants to merge 1 commit into
Draft
francois-unity wants to merge 1 commit into
francois-unity wants to merge 1 commit into
Conversation
Upstream gpui-ce#317 renamed `NotoSans[wdth,wght].subset.ttf` to `NotoSans[wdth-wght].subset.ttf`, and `typos.toml` only ignores the comma spelling. So `typos` reads `wdth`, the OpenType width axis tag, as a misspelled "width" in the asset’s file name and in `crates/gpui_ce_fonts/src/lib.rs`, and fails on every PR into `unity/a11y-automation`. The ignore pattern now accepts either separator, since the font’s README still names the comma spelling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets
typosaccept the Noto Sans font file under its new name, so thetyposjob passes again on PRs intounity/a11y-automation.Why: upstream gpui-ce#317 (now in this branch) renamed
NotoSans[wdth,wght].subset.ttftoNotoSans[wdth-wght].subset.ttf, andtypos.tomlonly ignores the comma spelling.typosthen readswdth, the OpenType width axis tag, as a misspelled “width” in the asset’s file name and incrates/gpui_ce_fonts/src/lib.rs:51, and fails (#7 shows it, job log). The ignore pattern now accepts either separator, because the font’s README still names the comma spelling. Upstream’stypos.tomlhas the same comma-only pattern.How to test
typosjob passes on this PR.typos1.47.2:typos --config typos.tomlreports nothing.