Skip to content

check for uid gid conflicts across entire LDAP tree #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Jun 9, 2025

Instead of checking the uidnumbers in the users OU and the gidnumbers in the groups,org_groups, pi_groups OUs, UnityLDAP::IDNumInUse now checks the uidnumbers and gidnumbers in the entire LDAP tree. Also, while choosing an ID for a new user, LDAP is queried only once instead of once-per-iteration-of-while-loop.

@simonLeary42 simonLeary42 marked this pull request as draft June 9, 2025 15:08
@simonLeary42 simonLeary42 force-pushed the main branch 6 times, most recently from 021a1af to 969c0ad Compare June 16, 2025 15:18
@simonLeary42 simonLeary42 changed the title check for uid conflicts outside users OU users might be outside users OU Jun 16, 2025
@simonLeary42 simonLeary42 force-pushed the fix-uid-conflict branch 3 times, most recently from 0f5df88 to f4b835d Compare June 16, 2025 21:36
@simonLeary42 simonLeary42 changed the title users might be outside users OU check for uid gid conflicts across entire LDAP tree Jun 17, 2025
@simonLeary42 simonLeary42 force-pushed the fix-uid-conflict branch 6 times, most recently from 67aa877 to 0adfec7 Compare June 17, 2025 15:08
@simonLeary42 simonLeary42 marked this pull request as ready for review June 17, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant