throw JSON errors, ensure file encoding, handle bad data in errorLog

[simonLeary42]

• create new utility \jsonEncode which always enables the flags JSON_THROW_ON_ERROR, JSON_UNESCAPED_SLASHES
• update phpopenldaper to also use the JSON_THROW_ON_ERROR flag
• replace uses of json_encode with jsonEncode
• document new convention that jsonEncode must be used instead of json_encode
• add pre-commit hook to enforce new convention
• add pre-commit hook to enforce another similar convention
• extend UnityHTTPD::getUploadedFileContents to encode the file with the specified encoding (default utf8) and do UnityHTTPD::badRequest upon encoding error
• extend UnityHTTPD::errorLog to handle the situtation where $data cannot be JSON encoded, so that the other information can still be logged

[Copilot]

Pull Request Overview

This PR introduces a new utility function jsonEncode() to standardize JSON encoding across the codebase with consistent error handling and formatting. The changes enforce the use of JSON_THROW_ON_ERROR and JSON_UNESCAPED_SLASHES flags by default, replace all instances of json_encode() with the new utility, and add enforcement mechanisms to prevent future use of the native function.

• Introduces jsonEncode() utility function with standardized flags
• Replaces all json_encode() calls with jsonEncode()
• Enhances file upload handling with encoding conversion support
• Improves error logging to handle JSON encoding failures gracefully

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
resources/lib/utils.php	Adds new jsonEncode() utility function and updates existing usage
resources/lib/UnityHTTPD.php	Updates error logging and file upload methods to use new utility and handle encoding
resources/lib/UnityWebhook.php	Replaces json_encode() with \jsonEncode()
resources/lib/UnityLDAP.php	Replaces json_encode() with \jsonEncode()
webroot/api/notices/index.php	Replaces json_encode() with jsonEncode()
test/assert-no-json_encode.bash	Adds test script to enforce jsonEncode() usage
test/assert-no-assert.bash	Adds test script to enforce ensure() usage
.pre-commit-config.yaml	Adds pre-commit hooks for enforcement
CONTRIBUTING.md	Updates guidelines to document new requirements

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}