Skip to content

Conversation

@jmeddick
Copy link
Collaborator

@jmeddick jmeddick commented Dec 5, 2025

I removed the constant REQUEST_BECOME_PI from UnitySQL and replaced it with the string "admin" where it was previously used.

@jmeddick jmeddick requested a review from simonLeary42 December 5, 2025 20:38
@jmeddick jmeddick self-assigned this Dec 5, 2025
@simonLeary42
Copy link
Collaborator

can you use UnitySQL::REQUEST_BECOME_PI instead of "admin"?

@simonLeary42
Copy link
Collaborator

simonLeary42 commented Dec 5, 2025

I shouldn't have told you to delete the constant, my bad

@jmeddick jmeddick closed this Dec 5, 2025
@jmeddick
Copy link
Collaborator Author

jmeddick commented Dec 5, 2025

can you use UnitySQL::REQUEST_BECOME_PI instead of "admin"?

sorry I closed this

should I put it back the way it was or just put the specific constant in every time instead of having it be a default value?

@jmeddick jmeddick reopened this Dec 5, 2025
@simonLeary42
Copy link
Collaborator

put the specific constant in every time instead of having it be a default value

@simonLeary42
Copy link
Collaborator

Thanks!

@simonLeary42 simonLeary42 merged commit dca4c46 into main Dec 9, 2025
2 of 3 checks passed
@simonLeary42 simonLeary42 deleted the remove-REQUEST_BECOME_PI branch December 9, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants